fix(ci): do not run rpcimportable on forks #3087

gartnera · 2024-11-04T16:27:39Z

Do not run the rpcimportable test on forks. This check will still be run in the mergequeue.

Summary by CodeRabbit

Chores
- Improved CI workflow by adding conditional execution for specific jobs on forked repositories.
- Enhanced comments for better clarity on workflow conditions.

coderabbitai · 2024-11-04T16:27:45Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The changes in this pull request modify the CI workflow defined in .github/workflows/ci.yml. A conditional execution has been added to the rpcimportable job to prevent it from running on forked repositories. This is implemented through an if condition that checks for the repository name. Comments have been added for clarity, while the overall structure of the CI workflow, including jobs for building, testing, and artifact uploading, remains unchanged.

Changes

File Path	Change Summary
.github/workflows/ci.yml	Added conditional execution for `rpcimportable` job to prevent running on forked repositories; added comments for clarity.

Possibly related PRs

ci: Add SARIF upload to GitHub Security Dashboard #2929: Modifications to the .github/workflows/semgrep.yml file involve changes to CI workflows, similar to those in the main PR.
ci: ensure variables are set for cache build #2948: This PR adds steps related to environment variables in a CI workflow, potentially connecting to the overall CI process.
ci: remove v2 migration test from scheduled CI and release workflow #3013: Adjustments to the CI logic in the .github/workflows/e2e.yml file align with the focus on CI workflows in the main PR.

Suggested labels

ci

Suggested reviewers

lumtis
skosito
fbac
swift1337

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

.github/workflows/ci.yml (2)
99-101: LGTM! Consider enhancing the comments.

The comments clearly explain the rationale. Consider adding a note about when exactly this job runs in the merge queue for better maintainability.
 # do not run this on forks as the are not installable
-# it will still be check in the merge queue in this case
+# it will still be checked in the merge queue (on 'merge_group' trigger)
101-101: Consider using environment variables for the repository name.

The condition is correct, but for maintainability, consider moving the repository name to an environment variable.
+env:
+  MAIN_REPOSITORY: 'zeta-chain/node'
+
 jobs:
   rpcimportable:
     runs-on: ubuntu-20.04
     timeout-minutes: 15
     # do not run this on forks as the are not installable
     # it will still be check in the merge queue in this case
-    if: github.repository == 'zeta-chain/node'
+    if: github.repository == env.MAIN_REPOSITORY

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b317941 and c01a032.

📒 Files selected for processing (1)

.github/workflows/ci.yml (1 hunks)

codecov · 2024-11-04T16:59:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.47%. Comparing base (a35a571) to head (43072ce).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3087      +/-   ##
===========================================
- Coverage    63.82%   63.47%   -0.35%     
===========================================
  Files          422      422              
  Lines        29700    29821     +121     
===========================================
- Hits         18955    18928      -27     
- Misses        9909    10059     +150     
+ Partials       836      834       -2

see 11 files with indirect coverage changes

gartnera added the no-changelog Skip changelog CI check label Nov 4, 2024

gartnera requested a review from a team as a code owner November 4, 2024 16:27

gartnera enabled auto-merge November 4, 2024 16:27

github-actions bot added the ci Changes to CI pipeline or github actions label Nov 4, 2024

lumtis approved these changes Nov 4, 2024

View reviewed changes

coderabbitai bot reviewed Nov 4, 2024

View reviewed changes

julianrubino approved these changes Nov 4, 2024

View reviewed changes

fix(ci): do not run rpcimportable on forks

43072ce

gartnera force-pushed the ci-rpcimportable-no-forks branch from c01a032 to 43072ce Compare November 4, 2024 16:52

gartnera added this pull request to the merge queue Nov 4, 2024

Merged via the queue into develop with commit 08eeb7f Nov 4, 2024
39 checks passed

gartnera deleted the ci-rpcimportable-no-forks branch November 4, 2024 17:26

gartnera mentioned this pull request Nov 4, 2024

fix(ci): do not run rpcimportable on forks #3089

Merged

jkan2 mentioned this pull request Nov 5, 2024

fix(ci): prevents semgrep from failing on forks #3092

Merged

5 tasks

coderabbitai bot mentioned this pull request Nov 8, 2024

test: initialize simulation tests for custom zetachain modules #3095

Merged

5 tasks

coderabbitai bot mentioned this pull request Dec 10, 2024

ci: add option to run e2e twice #3262

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): do not run rpcimportable on forks #3087

fix(ci): do not run rpcimportable on forks #3087

gartnera commented Nov 4, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 4, 2024 •

edited

Loading

Review skipped

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

codecov bot commented Nov 4, 2024 •

edited

Loading

fix(ci): do not run rpcimportable on forks #3087

fix(ci): do not run rpcimportable on forks #3087

Conversation

gartnera commented Nov 4, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Nov 4, 2024 • edited Loading

Review skipped

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 4, 2024 • edited Loading

Codecov Report

gartnera commented Nov 4, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 4, 2024 •

edited

Loading

codecov bot commented Nov 4, 2024 •

edited

Loading